You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, the Arrhenius reactions are getting converted to ArrheniusEP with alpha set to zero. Maybe we should loosen this behavior to allow both Arrhenius and ArrheniusEP? As well as provide warnings if someone tries to add other types of kinetics?
The text was updated successfully, but these errors were encountered:
I don't think training reactions should be EP. If they represent a specific reaction (as opposed to a family of reactions) an alpha is meaningless. What use case have you found for wanting to add them?
The minimal example broke because an ArrheniusEP was used in the training reactions rather than Arrhenius. See https://github.com/GreenGroup/RMG-Py/blob/master/rmgpy/data/kinetics/family.py#L844
However, the Arrhenius reactions are getting converted to ArrheniusEP with alpha set to zero. Maybe we should loosen this behavior to allow both Arrhenius and ArrheniusEP? As well as provide warnings if someone tries to add other types of kinetics?
The text was updated successfully, but these errors were encountered: