Extend saveTrainingReactions to take list input #1370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjohnson541
added
Status: Ready for Review
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
==========================================
+ Coverage 41.97% 41.98% +<.01%
==========================================
Files 169 169
Lines 27881 27889 +8
Branches 5492 5496 +4
==========================================
+ Hits 11703 11708 +5
- Misses 15388 15392 +4
+ Partials 790 789 -1
Continue to review full report at Codecov.
|
|
Would you mind if I combined this with the Edit: link |
|
Go for it! |
|
Merged with #1373. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some improvements to the saveTrainingReaction function that were useful in converting the rules in the database to training reactions. Note this is not interdependent with the rules to training reactions pull request itself, although it was used to run the script used to create that PR.