-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to calculate degeneracy for reactions involving "[CH]=C[N]" in reaction family Disproportionation #545
Comments
A resonance structure of the C2NH species raised this degeneracy error: |
could you provide the exact error trace that show which methods were hit? |
I actually saw a similar case recently, where RMG was unable to calculate degeneracy due to resonance structures.
|
Yes, looks similar. My trace is:
The KineticsError rises, probably due to this resonance. The two considered reactions are:
|
Looking at |
The degeneracy is not expected to be one. However the function expects only 1 reaction to come from the calculation. It expect RMG to find the multiple paths, and combine them into 1 reaction having a Of course this is a problem when you have multiple transition states, and shouldn't actually be combining the reactions into one. And also when there are resonance forms like what you guys are seeing, where RMG can't combine it into 1 reaction. |
Looks like the combining of reactions happens here: https://github.com/ReactionMechanismGenerator/RMG-Py/blob/master/rmgpy/data/kinetics/family.py#L1410 So it seems that we do try to combine species that are resonance isomers of each other at this point, so this should not typically cause an error. However, upon closer study I found that the reason is because
As you can see, the resonance isomers for [CH]=C=[N] includes C#C[N], but generating resonance isomers for C#C[N] does not produce anything. Which means our Therefore in the above case where the reaction that produces C#C[N] first, the 2nd reaction that produces [CH]=C=[N] is not seen as identical, even though had we reversed the order they would be considered identical. |
I think that explains my case as well. The product species in the reaction I posted has a benzene ring, so there are two possible kekule structures.
So starting with one of the resonance structures gives both kekule forms, while starting with the other one somehow doesn't. |
…s hysteresis. See RMG-Py issue ReactionMechanismGenerator#545
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue #545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue ReactionMechanismGenerator#545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
to include a birad. This addresses issue ReactionMechanismGenerator#545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
overhauled in #1055 |
to include a birad. This addresses issue ReactionMechanismGenerator#545 where RMG isn't able to calculate degeneracy since the resonance structures weren't explored for molecules like [CH]=C[N]
Apparently the Disproportionation family doesn't deal well with reactions of the type:
R.CH2R \ :CH2 + :N-CH-.CH <=> RCHR \ .CH3 + .N=C=.CH
I got errors like the following when running ethylamine pyrolysis simulations when specific reactions were added to the seed:
Unable to calculate degeneracy for reaction <Molecule "[CH2][CH]N"> + <Molecule "[CH]=C[N]"> <=> <Molecule "C[CH]N"> + <Molecule "C(=[CH])=[N]"> in reaction family Disproportionation. Expected 1 reaction but generated 2
The text was updated successfully, but these errors were encountered: