-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arkane takes a long time to run due to loading Julia dependencies #2547
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Patch in place in #2539, which might be cut down into smaller PRs one of which will exactly cover this issue. |
Arkane uses Julia for direct solution of the master equation ODE. |
Are you referring to the code that @hwpang pointed out here? #2631 (comment) If that's the case then I think Arkane has alternative solution methods already built in and we could possibly just say that in order to use the (probably better) Julia ones, they need to add the Julia deps? |
This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days. |
Fix nearing completion in #2631, not stale |
This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days. |
Not stale, see above |
This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days. |
This is actually implemented in #2741 |
Bug Description
Running
Arkane.py
takes much longer than expected (i.e. close to 1 hour rather than 1 second on a local machine) for simple TST calculations.How To Reproduce
Go to
RMG-Py/examples/arkane/reactions/
and runArkane.py
on any of theinput.py
files in any of the examples.You will see that Arkane starts executing, but slows down as it starts processing the Julia imports.
Expected Behavior
Arkane should finish running in just a few seconds.
Installation Information
3.2.0-115-g87b96e1b0
, RMG-database tag3.2.0
Additional Context
The slowdown is from Arkane importing RMG's
CoreEdgeReactionModel
, which imports RMG reactors, which then import the Julia modules (loading the Julia stuff is really slow.)Since I'm only using Arkane for conventional TST, I was able to get the runtime back to the expected ~1 seconds by commenting out all of the instances where
CoreEdgeReactionModel
orExplorerJob
are imported when Arkane.py is called.The text was updated successfully, but these errors were encountered: