Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating RMG-Py #2626

Closed
kirkbadger18 opened this issue Mar 6, 2024 · 6 comments
Closed

Updating RMG-Py #2626

kirkbadger18 opened this issue Mar 6, 2024 · 6 comments

Comments

@kirkbadger18
Copy link

Updating RMG-Py

When updating RMG-Py, should we also be recompiling the code with the "make" command, and also should we be updating the rmg conda environment from the updated .yaml file? If so could we add these steps to the website to make this more clear?

@JacksonBurns
Copy link
Contributor

Hi @kirkbadger18! Thanks for using RMG.

If you are using RMG from a docker image, you can just pull the latest image and run it in a separate container.

If you have installed from source, it depends.

  • If you update RMG-Py and we have changed any of the Cython files, you would need to run make clean and make again to incorporate the new changes.
  • If we have removed dependencies from the environment file (which is somewhat rare), you would be best served to re-build the entire environment. If we have only updated package versions then you can probably safely just update your existing environment.

Since it can be difficult to tell when changes have been made to Cython/the envrionment when pulling down a ton of changes, it may be best to always go through a quick environment + RMG rebuild if you haven't pulled in a while.

I agree that our docs are not thorough enough about this - this is the best we have right now. Adding to the todo list.

@oroppas
Copy link

oroppas commented Mar 8, 2024

Can RMG-Py be updated by using Anaconda?

@JacksonBurns
Copy link
Contributor

Can RMG-Py be updated by using Anaconda?

Unfortunately not. We have moved our primary distribution method to Docker, and the added difficulty of building conda packages means that we have not been keeping them up.

There are some ongoing efforts in #2539 but they are not yet ready for general use. We will provide and update if anything changes, but the best option now is to use Docker.

@oroppas
Copy link

oroppas commented Mar 10, 2024

Got it. Thanks!

Copy link

github-actions bot commented Jun 8, 2024

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Jun 8, 2024
@JacksonBurns
Copy link
Contributor

Closing this as resolved rather than stale.

@JacksonBurns JacksonBurns removed the stale stale issue/PR as determined by actions bot label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants