Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check correct use of .uncertainty and .uncertainty_si #144

Closed
rwest opened this issue Aug 29, 2013 · 0 comments
Closed

Check correct use of .uncertainty and .uncertainty_si #144

rwest opened this issue Aug 29, 2013 · 0 comments
Labels
Status: Stale This issue is out-of-date and may no longer be applicable

Comments

@rwest
Copy link
Member

rwest commented Aug 29, 2013

Commit fed3b59 fixed a horrible units bug revealed in the database export (see ReactionMechanismGenerator/RMG-database#21 ). There are probably other instances where we did it wrong. A global search for .uncertainty would be a good place to start, then check each occurrence is actually doing the right thing.

Also, some unit tests that check uncertainty handling in the Quantities package would be good.
@rwest rwest mentioned this issue Aug 29, 2013
Closed
@pierrelb pierrelb added the Status: Stale This issue is out-of-date and may no longer be applicable label Aug 28, 2015
@connie connie closed this as completed Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Stale This issue is out-of-date and may no longer be applicable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwest @connie @pierrelb