Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinuity in GAV Cp #1280

Closed
alongd opened this issue Feb 9, 2018 · 11 comments
Closed

Discontinuity in GAV Cp #1280

alongd opened this issue Feb 9, 2018 · 11 comments

Comments

@alongd
Copy link
Member

alongd commented Feb 9, 2018

Cp from GAV for [N]=S (and presumably many other species) has a discontinuity at 1500 K.
The groups all have reasonable values up to 1500 K, but I'm not sure where the Cp(inf) value is derived from, which probably causes this:
image

@alongd
Copy link
Member Author

alongd commented Feb 13, 2018

also true for azide

@mliu49
Copy link
Contributor

mliu49 commented Feb 13, 2018

This has been brought up before (#792). I think the conclusion last time was that group additivity was giving a bad estimate for Cp.

Cpinf is calculated by counting the number vibrational and rotational modes (here). In the two examples you give, it the Cpinf value appears to be much closer to the library values, which makes sense.

The solution would then be improving the group additivity estimates for these species.

@mliu49
Copy link
Contributor

mliu49 commented Feb 13, 2018

Also, note that the process of fitting a NASA polynomial removes the discontinuity, for better or for worse.

@alongd
Copy link
Member Author

alongd commented Feb 13, 2018

Thanks @mliu49
I agree that the GAV should be improved.
Should we add a fix such as limiting the cumulative Cp from groups to CPinf, or leave things as they are (and of course improve heteroatom GAV, which is a know task)?

@mliu49
Copy link
Contributor

mliu49 commented Feb 13, 2018

That's an interesting idea. Does Cp always monotonically increase with temperature? If so, it would definitely be possible to limit Cp to Cpinf.

@alongd
Copy link
Member Author

alongd commented Feb 13, 2018

I think Cp is a monotonic function of T: a molecule should only gain degrees of freedom as T increases.
I saw one esoteric contra-example (Schottky anomaly), but it should be safe to implement this assumption for the type of systems relevant to RMG.

@alongd
Copy link
Member Author

alongd commented Feb 14, 2018

Prof. Green corrected me in the last sub-group meeting that internal rotors have an ideal Cp = R at low T when they are hindered and behave as vibrations, while at higher T when they fully rotate they have Cp = 0.5 * R. Several of these throughout a molecule can cause Cp to decrease with increasing T.

We could define a more conservative Cp inf. estimation where all rotors are counted as having Cp = R (not 0.5 * R), which could be an upper boundary for GAV Cp at any T.

Edit: We should keeping the existing Cp inf. definition, the above will only be used for capping.

@github-actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

1 similar comment
@github-actions
Copy link

This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days.

@github-actions github-actions bot added the stale stale issue/PR as determined by actions bot label Sep 20, 2023
@github-actions github-actions bot added the abandoned abandoned issue/PR as determined by actions bot label Oct 21, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2023
@JacksonBurns
Copy link
Contributor

FWIW, this discontinuity is now gone (although the GAV plot still doesn't look great):

image

I'm going to close this as 'resolved' since the original error seems to have been resolved since this was first opened.

@JacksonBurns JacksonBurns removed stale stale issue/PR as determined by actions bot abandoned abandoned issue/PR as determined by actions bot labels Nov 2, 2023
@JacksonBurns
Copy link
Contributor

The azide example linked above has also been resolved:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants