From dcef9ab90b9d3a10cf248651c55a032792180100 Mon Sep 17 00:00:00 2001 From: Jackson Burns <33505528+JacksonBurns@users.noreply.github.com> Date: Wed, 12 Jun 2024 13:09:19 -0400 Subject: [PATCH] Apply suggestions from code review - clearer error messages Co-authored-by: Hao-Wei Pang <45482070+hwpang@users.noreply.github.com> --- rmgpy/pdep/sls.py | 4 ++-- rmgpy/rmg/input.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rmgpy/pdep/sls.py b/rmgpy/pdep/sls.py index 37e324e077..792a70e9ad 100644 --- a/rmgpy/pdep/sls.py +++ b/rmgpy/pdep/sls.py @@ -50,7 +50,7 @@ from diffeqpy import de from julia import Main except Exception as e: - warnings.warn( + logging.info( f"Unable to import Julia dependencies, original error: {str(e)}" ". Master equation method 'ode' will not be available on this execution." ) @@ -163,7 +163,7 @@ def get_rate_coefficients_SLS(network, T, P, method="mexp", neglect_high_energy_ if NO_JULIA: raise RuntimeError( "Required Julia dependencies for method 'ode' are not installed.\n" - "Please check your installation (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/index.html)." + "Please follow the steps to install Julia dependencies at https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/anacondaDeveloper.html." ) f = Main.eval( """ diff --git a/rmgpy/rmg/input.py b/rmgpy/rmg/input.py index db48e4be08..ba9b86f87a 100644 --- a/rmgpy/rmg/input.py +++ b/rmgpy/rmg/input.py @@ -1562,7 +1562,7 @@ def read_input_file(path, rmg0): if NO_JULIA: logging.error( "During runtime, import of Julia dependencies failed. To use phase systems and RMS reactors, install RMG-Py with RMS." - " (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/index.html)" + " (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/anacondaDeveloper.html)" ) logging.exception(e) raise