Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update R package requirements in "Local Development Configuration" wiki #121

Open
ArtemSokolov opened this issue Jan 3, 2020 · 9 comments

Comments

@ArtemSokolov
Copy link
Contributor

ArtemSokolov commented Jan 3, 2020

After performing a local build, I noticed that the following R packages were required, but not specified on the "Local Development Configuration" wiki:

Furthermore, the benchmark package listed in the dependencies seems to be archived on CRAN.

Lastly, I think it might be nice to give wiki readers an install.packages() line they can copy to their R environment, similar to what's provided with the sudo apt-get install ... lines. Consider including something like

install.packages( c("Rcpp", "RcppEigen", ...) )
devtools::install_github( "RcppCore/RcppNT2" )
devtools::install_github( "dcdillon/RcppHoney" )
@eddelbuettel
Copy link
Member

Yes. There is potentially a lot more on a per-post basis, depending on whether you want to recreate the posts. (I have been noodling with a pdf variant ...)

The benchmark is a typo. I meant rbenchmark.

I guess we could clean this up but I am not sure how high a priority it is. Thoughts, @jjallaire ?

@jjallaire
Copy link
Member

jjallaire commented Jan 3, 2020 via email

@eddelbuettel
Copy link
Member

Maybe the simplest fix would be to ... update the wiki page?

@ArtemSokolov as you have fresh eyes for the topic would you want to take a stab at it?

@ArtemSokolov
Copy link
Contributor Author

Honestly, other than the R package dependencies, I think the wiki page is in a pretty good shape! I'm happy to make the changes I proposed, but I don't think GitHub has an easy way to submit a pull request for wiki pages.

Let me know how you would like to proceed.

@eddelbuettel
Copy link
Member

Yes, the wiki pages are often left behind. I think one ... just edits as on any other wiki but storage is in git so one could roll-up if the need arose.

@ArtemSokolov
Copy link
Contributor Author

I think there's a permission control somewhere. Currently, there is no edit option visible to me in the Wiki tab.

@eddelbuettel
Copy link
Member

Hm. Do you see the Clone this wiki locally on the right side when you are on a post?

@ArtemSokolov
Copy link
Contributor Author

ArtemSokolov commented Jan 6, 2020

Yes. However, as discussed in this blog post, "while you can clone the wiki and make a change to your copy, you cannot submit a pull request as your copy is not “linked” with the original repository."

So, we just need to figure out an effective way to get any changes I make to appear in this primary fork.

@eddelbuettel
Copy link
Member

Maybe make the changes and email me a diff? I don't have time to dig now if there is mode somewhere between wiki 'locked and open to owners' and 'open to rest of world'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants