WIP Add new timeline states to try and bring in line with new API #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP trying to pull in changes from plexinc/plex-media-player@304f4da
The upstream commit seems to indicate that the "stopped" signal to the media server is now invalid, as the server needs to know if it was "finished" or intentionally cancelled.
It's unclear if the "cancelled" signal actually needs to be emitted, but it probably does for the server to behave properly.
To start with, I've just replaced most instances of
STOPPED
withFINISHED
, to try and simplify the patch.I won't know if this has been effective until I've had a chance to try it out. I'm building a new version of OpenPHT-Embedded based on LibreELEC.tv 9.0.1, which should also bring in proper RPi3b+ support.
I may try and cut a release of the new OpenPHT changes alone, as users of the current stable builds would benefit from a build based on 1.8 more closely, with just the timeline changes. It's unclear what instabilities LibreELEC 9.0.1 may bring in (and which bugs it may fix).