OpenAI-DotNet 8.2.5 (#367)

- Fixed ResponseObjectFormat deserialization when maxNumberOfResults is null
RageAgainstThePixel · Sep 14, 2024 · b2c0aa7 · b2c0aa7
1 parent 455c361
commit b2c0aa7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/OpenAI-DotNet/Common/FileSearchOptions.cs b/OpenAI-DotNet/Common/FileSearchOptions.cs
@@ -9,10 +9,11 @@ public sealed class FileSearchOptions
     {
         public FileSearchOptions() { }
 
-        public FileSearchOptions(int maxNumberOfResults, RankingOptions rankingOptions = null)
+        public FileSearchOptions(int? maxNumberOfResults, RankingOptions rankingOptions = null)
         {
             MaxNumberOfResults = maxNumberOfResults switch
             {
+                null => null,
                 < 1 => throw new ArgumentOutOfRangeException(nameof(maxNumberOfResults), "Max number of results must be greater than 0."),
                 > 50 => throw new ArgumentOutOfRangeException(nameof(maxNumberOfResults), "Max number of results must be less than 50."),
                 _ => maxNumberOfResults
@@ -22,10 +23,12 @@ public FileSearchOptions(int maxNumberOfResults, RankingOptions rankingOptions =
 
         [JsonInclude]
         [JsonPropertyName("max_num_results")]
-        public int MaxNumberOfResults { get; private set; }
+        [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)]
+        public int? MaxNumberOfResults { get; private set; }
 
         [JsonInclude]
         [JsonPropertyName("ranking_options")]
+        [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingDefault)]
         public RankingOptions RankingOptions { get; private set; }
     }
 }
diff --git a/OpenAI-DotNet/OpenAI-DotNet.csproj b/OpenAI-DotNet/OpenAI-DotNet.csproj
@@ -29,8 +29,10 @@ More context [on Roger Pincombe's blog](https://rogerpincombe.com/openai-dotnet-
     <AssemblyOriginatorKeyFile>OpenAI-DotNet.pfx</AssemblyOriginatorKeyFile>
     <IncludeSymbols>true</IncludeSymbols>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <Version>8.2.4</Version>
+    <Version>8.2.5</Version>
     <PackageReleaseNotes>
+Version 8.2.5
+- Fixed ResponseObjectFormat deserialization when maxNumberOfResults is null
 Version 8.2.4
 - Fixed ResponseObjectFormat deserialization when set to auto
 - Added RankingOptions to FileSearchOptions