Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform Module is not up to date #37

Closed
Viriathus1 opened this issue Sep 12, 2024 · 6 comments
Closed

Terraform Module is not up to date #37

Viriathus1 opened this issue Sep 12, 2024 · 6 comments

Comments

@Viriathus1
Copy link

The current terraform module is sufficiently out of step with the documentation and work on the main branch.

In order to use it we must use the deprecated input variables like update_route_table and route_table_id along with other input variables not being available like use_ssh.

Is it possible to get an estimated time on the next release?

@leo-the-nardo
Copy link

leo-the-nardo commented Sep 14, 2024

i had the same issue, i was able to use the new version cloning this repo and importing the local module as workaround. :

module "fck-nat" {

  source    = "./modules/fck-nat"
  name      = "fck-nat"
  vpc_id    = aws_vpc.cluster_vpc.id
  subnet_id = aws_subnet.public_subnet_az1.id
  # ha_mode              = true                 # Enables high-availability mode
  # use_cloudwatch_agent = true                 # Enables Cloudwatch agent and have metrics reported

  update_route_table = true
  route_tables_ids = {
    az1 = aws_route_table.router.id
    az2 = aws_route_table.router.id
  }
  use_ssh = true
  ssh_cidr_blocks = {
    ipv4 = [var.ssh_cidr]
    ipv6 = []
  }
  eip_allocation_ids                 = [aws_eip.router_eip.id]
}

@genghis-tuan
Copy link

Version 1.2.0 also doesn't handle x86_64 instance types in the regex which determines the local.is_arm. This causes the Terraform to fail when instance_type is, for example t2.micro with Call to function "regex" failed: pattern did not match any part of the given string.. This is fixed in the main branch. Would it be possible to get a release?

@Viriathus1
Copy link
Author

@leo-the-nardo yes, may have to use that workaround.

@genghis-tuan Second for this issue as well.

@RaJiska
Copy link
Owner

RaJiska commented Sep 21, 2024

@Viriathus1 @leo-the-nardo @genghis-tuan Just published a new version v1.3.0 which should include all the latest changes.

Apologies for the delay. Lately I have been experimenting a lot with true-HA mechanisms and wanted to see if I could get it done before releasing a new version (which I couldn't achieve).

@Viriathus1
Copy link
Author

@RaJiska thanks mate. On another note, currently getting a warning for aws_iam_role as a deprecated argument. The suggestion is to use aws_iam_role_policy. If this is not already on your radar, I'll take a look at it when I have time.

@bobsut
Copy link
Contributor

bobsut commented Oct 4, 2024

@Viriathus1 - Reported in Issue #41 and fixed in PR #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants