Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove path hardcodings in in-kernel restore #27

Closed
ShivanshRakesh opened this issue Aug 3, 2023 · 1 comment · Fixed by #42
Closed

remove path hardcodings in in-kernel restore #27

ShivanshRakesh opened this issue Aug 3, 2023 · 1 comment · Fixed by #42
Labels
bug Something isn't working in-kernel c/r issues related to the in-kernel c/r

Comments

@ShivanshRakesh
Copy link

Perhaps make args can be used instead of path hardcodings like this?

cricket/gpu/src/main.c

Line 215 in 4213b49

execute_command("set exec-wrapper env 'LD_PRELOAD=/home/eiling/projects/cricket/cpu/cricket-server.so' 'CRICKET_RESTORE=1'", !batch_flag);

@n-eiling n-eiling added in-kernel c/r issues related to the in-kernel c/r bug Something isn't working labels Dec 30, 2023
@n-eiling n-eiling changed the title remove path hardcodings remove path hardcodings in in-kernel restore Dec 30, 2023
@n-eiling n-eiling mentioned this issue Dec 30, 2023
Merged
@n-eiling
Copy link
Member

we had this already fixed on an inactive branch. I moved the commits to the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working in-kernel c/r issues related to the in-kernel c/r
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gpu improvements RWTH-ACS/cricket
2 participants
@n-eiling @ShivanshRakesh