Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModifyBridge] New bridge to modify feeds #4164

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

Mynacol
Copy link
Contributor

@Mynacol Mynacol commented Jul 27, 2024

Create a generic bridge that can modify the common fields of feeds with regular expressions.

@dvikan I found no other bridge to do something like that. Please look over it and merge if it fits.

Copy link

github-actions bot commented Jul 27, 2024

Pull request artifacts

Bridge Context Status
Modify 1 untitled (pr) ⚠️ (shutdown) 8192: preg_replace(): Passing null to parameter #2 ($replacement) of type arraystring is deprecated in bridges/ModifyBridge.php line 123

last change: Saturday 2024-08-10 20:18:53

Create a general bridge that can modify the common fields of feeds
with regular expressions.
@Mynacol
Copy link
Contributor Author

Mynacol commented Jul 27, 2024

I'm still not happy and finished with the enclosures elements. I wanted to modify a podcast feed, or rather its enclosure links. One of my podcast clients seems to only try the <enclosure> tag and not the <media:content> tag.

Ideally, we'd just modify the Mrss format to include an enclosure tag if there are elements in the enclosures array.

Edit: The respective feed is here

@dvikan
Copy link
Contributor

dvikan commented Jul 28, 2024

regarding podcast/media/itunes feeds we do indeed have a problem in which our feed parser does not capture all relevant properties.

in addition, rss-bridge does not generate arbitrary feeds but generates feeds with a mostly hardcoded list of properties (see MrssFormat and AtomFormat).

i can see the value in this bridge. but i think it's going to be rarely used.

@dvikan
Copy link
Contributor

dvikan commented Jul 29, 2024

See also #4015

@boyska

Additionally to the list of <enclosures>.
@dvikan dvikan merged commit 129b8a3 into RSS-Bridge:master Aug 10, 2024
7 checks passed
@Mynacol Mynacol deleted the modifybridge branch August 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants