-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2022Q4 Scenario prep exits with warnings #43
Comments
also relevant ticket on private ADO is here https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/10608 ℹ️ ADO ticket was re-opened with the relevant problem here as an acceptance criteria |
@AlexAxthelm for detail... In the file currently Line 2 ends with for it to be a valid CSV, and technically the file should end with a new line whether you want to modify the existing file in place, or create a new modified file and update the config here I leave up to you |
I think my preferred solution would be to not touch the file itself, but deal with it as part of reading. Maybe we could use |
I suppose I could adapt the workflow here to read in plain text and then pass that on to pacta.scenario.data.prep to process. FYI though... Antoine added that string to Line 2, so it's not like it's truly a "raw" file. |
TBH, given that the column that we are concerned with was added manually to begin with, seems like it makes more sense just to fill it in properly... (or remove it entirely?) |
Closing, as I have altered the source file to include the column in all rows. |
From a recent run of 2022Q4 Scenario prep:
likely relates to RMI-PACTA/pacta.scenario.data.preparation#29 (comment)
The text was updated successfully, but these errors were encountered: