Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new docker build action #14

Closed
jdhoffa opened this issue Feb 20, 2024 · 6 comments · Fixed by #36
Closed

Implement new docker build action #14

jdhoffa opened this issue Feb 20, 2024 · 6 comments · Fixed by #36
Assignees
@AlexAxthelm
Labels
ADO trigger to create a ticket on ADO upkeep maintenance, infrastructure, and similar

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Feb 20, 2024 •
edited by azure-boards bot
Loading 

          All I can do really is very cautiously approve this, and likely try to test the action in the wild on a relevant repo!

Originally posted by @jdhoffa in RMI-PACTA/actions#56 (review)

AB#9930
@jdhoffa jdhoffa added the upkeep maintenance, infrastructure, and similar label Feb 20, 2024
@jdhoffa jdhoffa self-assigned this Feb 20, 2024
@jdhoffa jdhoffa added the ADO trigger to create a ticket on ADO label Feb 20, 2024
@AlexAxthelm
Copy link
Contributor

AlexAxthelm commented Feb 20, 2024 •
edited
Loading

FYI, I'll be adding the actions to workflow.factset (RMI-PACTA/workflow.factset#54) soon. I'll let you know how that goes.

@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 6, 2024

@AlexAxthelm I believe you are building a much broader Action that takes care of everything. Is this issue still relevant?

@AlexAxthelm
Copy link
Contributor

Still relevant. have a couple of housekeeping things to take care of in that action, but it's available for use as part of https://github.com/RMI-PACTA/actions/blob/main/.github/workflows/docker.yml.

The big that's missing compared to previous workflows we've used is that it doesn't add a comment to PRs.

@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 6, 2024

Sounds good!

@jdhoffa jdhoffa removed their assignment Apr 10, 2024
@AlexAxthelm
Copy link
Contributor

Partially resolved in #36. full resolution depends on RMI-PACTA/actions#58

@AlexAxthelm AlexAxthelm self-assigned this Apr 16, 2024
@cjyetman cjyetman mentioned this issue Apr 17, 2024
Closed
@cjyetman
Copy link
Member

I'm gonna call this closed by #36, and I opened a new issue for using the platform specification once it's ready in #45

@cjyetman cjyetman linked a pull request Apr 17, 2024 that will close this issue
add docker action from RMI-PACTA/actions #36
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexAxthelm AlexAxthelm

Labels
ADO trigger to create a ticket on ADO upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add docker action from RMI-PACTA/actions RMI-PACTA/workflow.scenario.preparation
3 participants
@cjyetman @AlexAxthelm @jdhoffa