-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github action to check if outputs already exist #103
Comments
@AlexAxthelm there are benchmark inputs that are scraped on the fly using the I guess the hash would need to depend also on the result of that scraping to be complete? |
Conceptually, makes sense to me, though...
Scratch all that... I forgot how this repo is being used. I'll have to think about that once my memory has improved. |
This happens a lot. we push a lot of changes to workflow.transition.monitor that aren't changing any of the processing code, or don't require a rebuild of the docker image (or rather, the entire image can be rebuilt from cache) |
closed in #105 |
Runnning index prep is a long process that's part of the current build process for
workflow.transition.monitor
, and will probably be forworkflow.pacta.webapp
as well.Given that the indices don't actually change that much, it would make sense to do a check if the process needs to actually run, or if we can bypass it, and return the previous results instead.
My general thinking is to construct a hash based on:
pacta-data
,benchmark_inputs
filesand use that as a versioning key, and then we can check if the appropriate files exist in the blob store/AFS
so it would look something like:
cc @jdhoffa @cjyetman, Do I have the hashkeys right, or am I missing something?
The text was updated successfully, but these errors were encountered: