Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: update startYear value to be aligned with config date #104

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Dec 9, 2024

Everything else points to 2023, but startYear = 2022

Maybe closes #103

…gs date

Everything else points to `2023`, but `startYear = 2022`
@jdhoffa jdhoffa requested a review from AlexAxthelm as a code owner December 9, 2024 22:00
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.35%. Comparing base (29636fa) to head (f8288ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   18.35%   18.35%           
=======================================
  Files           4        4           
  Lines         414      414           
=======================================
  Hits           76       76           
  Misses        338      338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 9, 2024

Docker build status

commit_time git_sha image
2024-12-09T22:00:25Z f8288ab ghcr.io/rmi-pacta/workflow.pacta:pr-104

@AlexAxthelm AlexAxthelm merged commit 56bdc48 into main Dec 10, 2024
31 checks passed
@AlexAxthelm AlexAxthelm deleted the jdhoffa-patch-1 branch December 10, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: manifest.json file of the analysis outputs has misaligned output value of startYear
2 participants