Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly flag if portfolio should be checked in calc_wieghts prechecks #85

Closed
AlexAxthelm opened this issue Aug 14, 2024 · 1 comment

Comments

@AlexAxthelm
Copy link
Contributor

          Ah, yeah I see the point.

I guess the flag should really indicate something along the lines of "should I expect output files from the audit process to have been created already?"

So maybe something along the lines of:

  analysis_prechecks(
    total_portfolio_path = NULL,
    pacta_data_dir = pacta_data_dir,
    output_dir = output_dir,
    check_audit_outputs = TRUE
  )

and in run_pacta it would be:

  analysis_prechecks(
   ...,
    check_audit_outputs = FALSE
  )

Originally posted by @jdhoffa in #83 (comment)

@AlexAxthelm
Copy link
Contributor Author

Closed via #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant