Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/34 enable parameter parsing #47

Merged
merged 34 commits into from
Dec 13, 2024
Merged

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Dec 11, 2024

Enables command-line parameter parsing (params object), and (via #49) generation of PACTA results (rather than assuming that results are already generated)

Should match syntax for workflow.pacta.webapp (including using reporting key for output-related parameters)

Copy link

github-actions bot commented Dec 11, 2024

Docker build status

commit_time git_sha image
2024-12-13T15:48:24Z 06a57c9 ghcr.io/rmi-pacta/workflow.pacta.dashboard:main

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 181 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8843f86) to head (06a57c9).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
R/prepare_pacta_dashboard_data.R 0.00% 63 Missing ⚠️
R/prepare_schema_files.R 0.00% 41 Missing ⚠️
R/run_dashboard_workflow.R 0.00% 41 Missing ⚠️
R/build_dashboard.R 0.00% 36 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main     #47    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         23      25     +2     
  Lines       1052    1192   +140     
======================================
- Misses      1052    1192   +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 13, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-13 16:03 UTC

@jdhoffa
Copy link
Member

jdhoffa commented Dec 13, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RMI-PACTA.github.io/workflow.pacta.dashboard/pr-preview/pr-47/
on branch gh-pages at 2024-12-13 14:00 UTC

Woohoo!
All dashboards are looking like I would expect 😊

@AlexAxthelm
Copy link
Contributor Author

@jdhoffa it looks like tech mixes are coming through clean here.

@jdhoffa
Copy link
Member

jdhoffa commented Dec 13, 2024

Indeed they are!
The fixes seemed to work well 😊

@jdhoffa
Copy link
Member

jdhoffa commented Dec 13, 2024

Not sure they are directly relevant to this PR (they might be?)
but I imagine these two PRs will fix some potential funkiness too:
RMI-PACTA/workflow.pacta#105
RMI-PACTA/workflow.pacta.webapp#27

@AlexAxthelm AlexAxthelm marked this pull request as ready for review December 13, 2024 15:08
@AlexAxthelm AlexAxthelm requested a review from jdhoffa December 13, 2024 15:08
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinyyyyy little typo, otherwise looks great 😊

Tested by

  • Reviewing all changes carefully through web GUI (especially that all year values in all configs aligned
  • Reviewed all dashboard artifacts created in the PR-preview

R/run_dashboard_workflow.R Outdated Show resolved Hide resolved
tests/config/default_2022Q4.json Show resolved Hide resolved
@AlexAxthelm AlexAxthelm requested a review from jdhoffa December 13, 2024 15:45
@AlexAxthelm AlexAxthelm merged commit 7e154bc into main Dec 13, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants