-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/34 enable parameter parsing #47
Conversation
Docker build status
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 23 25 +2
Lines 1052 1192 +140
======================================
- Misses 1052 1192 +140 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Jackson Hoffart <[email protected]>
Co-authored-by: Jackson Hoffart <[email protected]>
Integrate `workflow.pacta` analysis in dashboard generation
|
Woohoo! |
@jdhoffa it looks like tech mixes are coming through clean here. |
Indeed they are! |
Not sure they are directly relevant to this PR (they might be?) |
rather than redfinining here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tinyyyyy little typo, otherwise looks great 😊
Tested by
- Reviewing all changes carefully through web GUI (especially that all
year
values in allconfigs
aligned - Reviewed all dashboard artifacts created in the PR-preview
Enables command-line parameter parsing (
params
object), and (via #49) generation of PACTA results (rather than assuming that results are already generated)Should match syntax for
workflow.pacta.webapp
(including usingreporting
key for output-related parameters)