-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for desired options in raw data #11
Comments
After looking into this a bit, I'm not sure this is entirely feasible/desirable. Hypothetically, at the beginning of this script just after all the options are set we could verify that the set options, e.g. list of desired sectors, are available in the appropriate datasets, but that would imply loading those datasets to be able to check, and since memory management in this script is a big deal, I fear the cost might outweigh the benefit. @jdhoffa? |
A fair and valid point. I would think in that case that having good initial checks in every relevant function is a suitable alternative. These errors (and warnings I guess, if applicable) should have informative and clear messages when crucial data is lacking. I don't know if that already exists sufficiently? If it does then happy to close this, otherwise I would suggest we open a new issue in NIT: Effective |
I agree that a possibly suitable alternative would be to add checking for crucial input in functions in pacta.data.preparation. Issue opened here https://github.com/RMI-PACTA/pacta.data.preparation/issues/327 |
Closing in favour of https://github.com/RMI-PACTA/pacta.data.preparation/issues/327 |
It would be advantageous to check if the desired options (scenarios, sectors, etc.) exist in the raw input data files (AR data, scenario data, etc.) before running the full process.
Supersedes https://github.com/RMI-PACTA/pacta.data.preparation/issues/63
The text was updated successfully, but these errors were encountered: