Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MSCI ETFs from 2023Q4 benchmark preparation config #6

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Jun 28, 2024

@cjyetman cjyetman requested review from AlexAxthelm and jdhoffa June 28, 2024 12:18
Copy link

Docker build status

commit_time git_sha image
2024-06-28T12:18:12Z 860996d ghcr.io/rmi-pacta/workflow.benchmark.preparation:pr-6

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, concise and clean!!

LGTM

@cjyetman cjyetman merged commit 080b88b into main Jun 28, 2024
8 checks passed
@cjyetman cjyetman deleted the cjyetman-patch-1 branch June 28, 2024 12:30
jdhoffa added a commit to RMI-PACTA/workflow.prepare.pacta.indices that referenced this pull request Jul 17, 2024
The configuration currently points to benchmark input data containing both the real MSCI data and MSCI ETF data. 

It was decided in https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/11078/ to only include ETF data if there was no real index data.

This was implemented here: RMI-PACTA/workflow.benchmark.preparation#6

But requires a similar change in the configuration file, that this PR hopes to address. 

Likely closes:
https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/11076
and
https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/11078
jdhoffa added a commit to RMI-PACTA/workflow.prepare.pacta.indices that referenced this pull request Jul 17, 2024
The configuration currently points to benchmark input data containing both the real MSCI data and MSCI ETF data. 

It was decided in https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/11078/ to only include ETF data if there was no real index data.

This was implemented here: RMI-PACTA/workflow.benchmark.preparation#6

But requires a similar change in the configuration file, that this PR hopes to address. 

Likely closes:
https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/11076
and
https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/11078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants