Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release r2dii.plot 0.4.0 #526

Closed
21 tasks done
MonikaFu opened this issue Dec 15, 2023 · 14 comments · Fixed by #562
Closed
21 tasks done

Release r2dii.plot 0.4.0 #526

MonikaFu opened this issue Dec 15, 2023 · 14 comments · Fixed by #562
Assignees

Comments

@MonikaFu
Copy link
Collaborator

MonikaFu commented Dec 15, 2023

Prepare for release:

Submit to CRAN:

  • usethis::use_version('minor')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • Add preemptive link to blog post in pkgdown news menu
  • usethis::use_github_release()
  • usethis::use_dev_version(push = TRUE)
  • Finish blog post
  • Tweet
@jdhoffa
Copy link
Member

jdhoffa commented Jan 5, 2024

Are we planing to release r2dii.plot in the (relatively) immediate future?

@jdhoffa jdhoffa self-assigned this Jan 26, 2024
@jdhoffa
Copy link
Member

jdhoffa commented Jan 29, 2024

I aim to close:
#357, #465, #536 and #540
ahead of this release.

@jdhoffa
Copy link
Member

jdhoffa commented Feb 16, 2024

#357 , #465 , #536 and #540 have been closed.

@MonikaFu if you are comfortable with it, I will initiate a CRAN release next week. If you would prefer to wait until certain other issues are closed, please identify which issues!

:-)

@MonikaFu
Copy link
Collaborator Author

I'd like to issues #546 and #548 to be solved before the release. Currently some of the functions do not have adequate checks.

@jdhoffa
Copy link
Member

jdhoffa commented Feb 28, 2024

@MonikaFu #546 and #548 have been closed.
Are we good to begin the release process here?

@MonikaFu
Copy link
Collaborator Author

Yup! I believe so 🚀

@jdhoffa
Copy link
Member

jdhoffa commented Feb 28, 2024

@MonikaFu you should receive an e-mail with the results of devtools::check_win_devel() shortly

@jdhoffa
Copy link
Member

jdhoffa commented Feb 28, 2024

I am skipping "Draft a Blog Post" because we don't have a blog.

@jdhoffa
Copy link
Member

jdhoffa commented Feb 29, 2024

Heya @MonikaFu did you get the results of the devtools::check_win_devel() run? does everything look good?

@MonikaFu
Copy link
Collaborator Author

Sorry, forgot about it. Yes, looks good to me: https://win-builder.r-project.org/95U3FyBRgoxD/

There is one note but as far as I remember it is expected when you do a major update?

@jdhoffa
Copy link
Member

jdhoffa commented Feb 29, 2024

Yup, that note is warning you that we have a development version number (e.g. X.Y.Z.9000), but that is expected :-)

@MonikaFu
Copy link
Collaborator Author

MonikaFu commented Feb 29, 2024

Ah right. About the version, in the issue it says usethis::use_version('minor'), shouldn't it be major though? As we are changing the API?

@jdhoffa
Copy link
Member

jdhoffa commented Feb 29, 2024

Since we are still in v0.Y.Z we do not need to do a major bump! Only versions after 1.Y.Z require that.
But yes, in general, breaking changes would require a major bump

@jdhoffa
Copy link
Member

jdhoffa commented Mar 4, 2024

All done! Thanks @MonikaFu

  • version 0.4.0 on CRAN
  • main bumped to development version 0.4.0.9000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants