Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target_market_share now correctly handles input scenario with a hyphen in name #464

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Feb 1, 2024

Closes #425

@jdhoffa jdhoffa self-assigned this Feb 1, 2024
@jdhoffa jdhoffa marked this pull request as ready for review February 6, 2024 10:46
@jdhoffa jdhoffa requested a review from jacobvjk February 6, 2024 10:46
@jdhoffa jdhoffa added the bug an unexpected problem or unintended behavior label Feb 6, 2024
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: tidyr::separate() is superseded by tidyr::separate_wider_delim()

.data$name,
into = c("name", "metric"),
sep = "-",
extra = "merge"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shockingly simple fix :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favourite kind!

I am going to try to address your knit comment while I'm here also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah actually no I'm not. That new function is still experimental, I will wait until it is stable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New issue #471

@jdhoffa jdhoffa merged commit 8be430f into main Feb 6, 2024
24 checks passed
@jdhoffa jdhoffa deleted the 425-split_scenario_names_correctly branch February 6, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

separate_metric_from_name() splits up some scenario names wrong
2 participants