Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #445
This PR:
target_sda(by_company = TRUE)
uses the emission intensity value of the final year of theadjusted_scenario_*
to calculate thetarget_*
values for companies when using the SDA approachright_join
, that introducesNAs
for every year past the emission intensity projection when runningtarget_sda()
at the company level.target_summary_groups
was adjusted to loan book or company level at the top level oftarget_sda()
compute_loanbook_targets()
, which gains an argument,by_company
, to adjust the grouping variables as needed.compute_loanbook_targets()
was one pipe, which is now split into multiple parts.scenario_with_p
values are correctly merged for every individual company, ensuring the relevant convergence value exists when calculating company targetstarget_sda()
calculation is updated, as it previously contained NAs and wrong values due to this bug