Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ write an adapter for banks-style PACTA data outputs #518

Open
jdhoffa opened this issue Dec 4, 2024 · 7 comments
Open

✨ write an adapter for banks-style PACTA data outputs #518

jdhoffa opened this issue Dec 4, 2024 · 7 comments

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Dec 4, 2024

Not sure how feasible this is, but if we could adapt this data generation repo to optionally take banks data as input, banks could also benefit from the dashboard:
https://rmi-pacta.github.io/pacta-dashboard-svelte/

Obviously no action required here yet
Just musing.

FYI @jacobvjk

@AlexAxthelm
Copy link
Contributor

Seems like it might be better to have P4B output the expected format, than to have multiple formats of input on the workflow.pacta.* reporting tools

@jacobvjk
Copy link
Member

jacobvjk commented Dec 6, 2024

@jdhoffa @AlexAxthelm I am not familiar with this repo at all yet. When you say "data generation repo" you are referring to this one or another one?

@jdhoffa
Copy link
Member Author

jdhoffa commented Dec 6, 2024

Seems like it might be better to have P4B output the expected format, than to have multiple formats of input on the workflow.pacta.* reporting tools

That's a trickier ask, since r2dii is currently in production, and has several active users. Any breaking changes in output format would cause trouble for those users.

One option would be to create an adapter package

@jdhoffa
Copy link
Member Author

jdhoffa commented Dec 6, 2024

@jdhoffa @AlexAxthelm I am not familiar with this repo at all yet. When you say "data generation repo" you are referring to this one or another one?

This repo. It's basically just a data formatting repo

@jacobvjk
Copy link
Member

jacobvjk commented Dec 6, 2024

Seems like it might be better to have P4B output the expected format, than to have multiple formats of input on the workflow.pacta.* reporting tools

That's a trickier ask, since r2dii is currently in production, and has several active users. Any breaking changes in output format would cause trouble for those users.

One option would be to create an adapter package

yea, fundamentally changing p4b output format seems like a non-starter. Agree that either another repo or adding an adapter function somewhere may be more realistic

@AlexAxthelm
Copy link
Contributor

Vote to move this issue to a different repo (with the idea that building a general adapter makes sense, since it could be used for Interactive report too)

@jdhoffa
Copy link
Member Author

jdhoffa commented Dec 10, 2024

makes sense, I just don't think another (better) repo exists yet...
Maybe r2dii.analysis?

@AlexAxthelm AlexAxthelm transferred this issue from RMI-PACTA/workflow.pacta.dashboard Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants