Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move r2dii.match from Suggests to Imports #455

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Move r2dii.match from Suggests to Imports #455

merged 1 commit into from
Jan 31, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jan 26, 2024

Closes #351

@jdhoffa jdhoffa requested a review from jacobvjk January 26, 2024 16:40
@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 31, 2024

@jacobvjk could I get a review on this when you get a chance?

jacobvjk
jacobvjk approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdhoffa jdhoffa merged commit f0ef6a5 into main Jan 31, 2024
26 checks passed
@jdhoffa jdhoffa deleted the 351-depend_on_r2dii_match branch January 31, 2024 10:18
This was referenced Jan 31, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobvjk jacobvjk jacobvjk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rethink how we manage the dependency with r2dii.match
2 participants
@jdhoffa @jacobvjk