Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/0.3.0 cran update #449

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Release/0.3.0 cran update #449

merged 4 commits into from
Jan 8, 2024

Conversation

AlexAxthelm
Copy link
Contributor

Updates to remove NOTEs from CRAN checks.

@jdhoffa
Copy link
Member

jdhoffa commented Jan 4, 2024

Is this stale? or on CRAN?

Any final steps need to be merged?

@AlexAxthelm AlexAxthelm requested a review from jdhoffa January 8, 2024 13:38
@AlexAxthelm
Copy link
Contributor Author

0.3.0 is on CRAN. Merging this would bring main to current with what's on CRAN.

@jdhoffa
Copy link
Member

jdhoffa commented Jan 8, 2024

pkgdown action failing.

Seems like the pkgdown site doesn't like our current data (or something similar). I will look into this in a separate issue

@jdhoffa jdhoffa mentioned this pull request Jan 8, 2024
Closed
jdhoffa
jdhoffa approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from pkgdown failure.

@jdhoffa jdhoffa merged commit 1c040b6 into main Jan 8, 2024
22 of 23 checks passed
@jdhoffa jdhoffa deleted the release/0.3.0-CRAN-UPDATE branch January 8, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @jdhoffa