Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate: "Re: CRAN packages with reports of unconditional use of Suggests #352

Closed
maurolepore opened this issue Jul 30, 2021 · 1 comment
Assignees

Comments

@maurolepore
Copy link
Contributor

maurolepore commented Jul 30, 2021

tl;dr the problem relates to #351

CRAN reports problems in examples and tests caused because r2dii.match can't be installed, in turn because stringdist can't be installed.

We could fix this problem by managing the dependency with r2dii.match in a better way (see #351).

ERROR in examples and tests

From https://www.stats.ox.ac.uk/pub/bdr/noSuggests/r2dii.analysis.out

* using R Under development (unstable) (2021-07-28 r80671)
* using platform: x86_64-pc-linux-gnu (64-bit)

...

* checking examples ... ERROR
Running examples in ‘r2dii.analysis-Ex.R’ failed
The error most likely occurred in:

> ### Name: join_ald_scenario
> ### Title: Join a data-loanbook object to the ald and scenario
> ### Aliases: join_ald_scenario
> 
> ### ** Examples
> 
> installed <- requireNamespace("r2dii.data", quietly = TRUE) &&
+   requireNamespace("r2dii.match", quietly = TRUE)
> if (!installed) stop("Please install r2dii.match and r2dii.data")
Error: Please install r2dii.match and r2dii.data

...

* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ...
  Running ‘spelling.R’
  Running ‘testthat.R’ [18s/19s]
 [19s/19s] ERROR
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
  > library(testthat)
  > library(r2dii.analysis)
  > 
  > test_check("r2dii.analysis")
  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error (test-join_ald_scenario.R:3:1): (code run outside of `test_that()`) ───
  Error: there is no package called 'r2dii.match'

CRAN's email:

From: Prof Brian Ripley <[email protected]>
Date: Thu 29. Jul 2021 at 11:06
Subject: CRAN packages with reports of unconditional use of Suggests
...
There is now a directory of check results using _R_DEPENDS_ONLY=true at
https://www.stats.ox.ac.uk/pub/bdr/noSuggests/ which will show what the
issues currently are.  It includes a README.txt.
@maurolepore
Copy link
Contributor Author

This is being addressed in finer grained PRs (see #356)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant