-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Global search #42
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3f1590e
New Global search
maurolepore 8edd82c
Polish
maurolepore ab547c6
A bit more readable
maurolepore 603b294
Style
maurolepore e6a3fdf
Use relative path
maurolepore 7758881
Suggest dverse and DT to avoid build failure on GH Actions
maurolepore 217d7ed
Merge branch 'main' into global-search
jdhoffa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,4 @@ | |
| ^pkgdown$ | ||
| ^LICENSE\.md$ | ||
| ^codecov\.yml$ | ||
| ^vignettes/articles$ | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| *.html | ||
| *.R |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| --- | ||
| title: "Global search" | ||
| --- | ||
|
|
||
| ```{r, include = FALSE} | ||
| knitr::opts_chunk$set( | ||
| echo = FALSE, | ||
| collapse = TRUE, | ||
| comment = "#>" | ||
| ) | ||
| ``` | ||
|
|
||
| ```{r setup, message=FALSE} | ||
| library(pacta.data.scraping) | ||
| library(pacta.data.validation) | ||
| library(pacta.executive.summary) | ||
| library(pacta.interactive.plot) | ||
| library(pacta.portfolio.allocate) | ||
| library(pacta.portfolio.audit) | ||
| library(pacta.portfolio.import) | ||
| library(pacta.portfolio.report) | ||
| library(pacta.portfolio.utils) | ||
| ``` | ||
|
|
||
| ```{r} | ||
| packages <- c( | ||
| "pacta.data.scraping", | ||
| "pacta.data.validation", | ||
| "pacta.executive.summary", | ||
| "pacta.interactive.plot", | ||
| "pacta.portfolio.allocate", | ||
| "pacta.portfolio.audit", | ||
| "pacta.portfolio.import", | ||
| "pacta.portfolio.report", | ||
| "pacta.portfolio.utils" | ||
| ) | ||
|
|
||
| url_template <- "https://rmi-pacta.github.io/{package}/reference/{topic}.html" | ||
| docs <- dverse::document_universe(packages, url_template) | ||
|
|
||
| exported_helpfiles <- docs %>% | ||
| dplyr::filter(type == "help", keyword != "internal" | is.na(keyword)) %>% | ||
| dplyr::select(topic, title, package) | ||
|
|
||
| exported_helpfiles %>% DT::datatable(escape = FALSE) | ||
| ``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI intro, tutorials, and news also seem unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were intentionally left in because they're common/default/normal things to have in a pkgdown site, and the goal of this line is to define the structure/order of these items if they exist, so if one of those things is added in the future it will automatically show up in the menu and be placed properly in line with how our other pkgdown sites are structured.
On that note, does this PR mean that we can no longer use articles in the future because of this change? i.e. we have to choose between having this "Global search" function and having the ability to use articles?