Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge pacta.sit.rep functionality with this repo, and render the report as a page in the pkgdown site #43

Closed
jdhoffa opened this issue Nov 26, 2024 · 4 comments · Fixed by #44
Labels
feature a feature request or enhancement

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Nov 26, 2024

@cjyetman it might/ probably makes sense to combine https://github.com/RMI-PACTA/pacta.sit.rep with this repo, and render the situation report table as a page in the pkgdown site of pactaverse, what do you think?

@jdhoffa jdhoffa added the feature a feature request or enhancement label Nov 26, 2024
@cjyetman
Copy link
Member

At the moment, the sit.rep tables require constant manual updates to be actually up-to-date, which I'm not to keen on. If we got it to build a static page that pulls the most recent info whenever it's loaded, then I think it could be useful without being burdensome.

@jdhoffa
Copy link
Member Author

jdhoffa commented Nov 26, 2024

Totally! One option could be to only migrate the portion of the pacta.sit.rep that are generated statically.
I also notice that some issues are open towards this: RMI-PACTA/pacta.sit.rep#35

Alternatively, we can implement it entirely statically in pacta.sit.rep first, and then migrate it over.

Just wanted to track the intention to do so in this ticket :-)

@cjyetman
Copy link
Member

Would this work? It's all static markdown/html, but the values are all dynamic, except for lifecycle which we don't assign in any programmatic way.

repo lifecycle status coverage r-universe CRAN dev maintainer
pacta.data.scraping
pacta.portfolio.import
pacta.data.validation
pacta.portfolio.allocate
pacta.portfolio.audit
pacta.portfolio.report
pacta.portfolio.utils
pacta.executive.summary
pacta.interactive.plot

@jdhoffa
Copy link
Member Author

jdhoffa commented Nov 27, 2024

looks good to me!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants