New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to using singular names of asset class #29

Open

AlexAxthelm opened this issue Oct 12, 2023 · 0 comments

Collaborator

AlexAxthelm commented Oct 12, 2023

Our list of acceptable asset_type values is a bit mixed up: c("Bonds", "Equity", "Funds", "Others")

In https://github.com/RMI-PACTA/pacta.data.preparation/pull/261 we align this to c("Bond", "Equity", "Fund", "Other"), and then immediately change it in place to what it was (to ensure no breaking changes).

We may consider aligning our downstream repos to these new values.

Migration of https://github.com/RMI-PACTA/pacta.interactive.report/issues/177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment