Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize reading of raw ABCD with read_raw_abcd() #77

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

cjyetman
Copy link
Member

No description provided.

@cjyetman cjyetman requested a review from jacobvjk as a code owner August 20, 2024 21:38
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
nb: one tiny nit/question

)
)

dplyr::mutate(abcd, year = as.integer(.data$year))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: were you not a proponent of adding an explicit return() at the end of functions in the past? I personally still like that, but no blocker of course

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was! But I stopped trying to swim upstream.

@cjyetman cjyetman merged commit d6b57e6 into main Aug 21, 2024
9 checks passed
@cjyetman cjyetman deleted the read_raw_abcd() branch August 21, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants