Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain pak usage #351

Merged
merged 3 commits into from
Dec 12, 2024
Merged

explain pak usage #351

merged 3 commits into from
Dec 12, 2024

Conversation

jacobvjk
Copy link
Member

explain what pak is for

@jacobvjk jacobvjk requested a review from jdhoffa December 12, 2024 16:12
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.05%. Comparing base (a060058) to head (c5cadca).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          29       29           
  Lines        3269     3269           
=======================================
  Hits         2617     2617           
  Misses        652      652

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-12 16:30 UTC

jdhoffa
jdhoffa requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid installing software on someone's computer with a copy paste code chunk :-)

That should always be a clear user decision

vignettes/cookbook_preparatory_steps.Rmd Outdated Show resolved Hide resolved
vignettes/cookbook_preparatory_steps.Rmd Outdated Show resolved Hide resolved
@jacobvjk jacobvjk requested a review from jdhoffa December 12, 2024 16:17
@jacobvjk jacobvjk merged commit e285309 into main Dec 12, 2024
11 checks passed
@jacobvjk jacobvjk deleted the explain-pak branch December 12, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman cjyetman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobvjk @cjyetman @jdhoffa