Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use valid scenario and scenario_source values in tests #339

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Dec 11, 2024

⚠️ sorry for the unrelated whitespace changes, but might as well get rid of them while we're here

⚠️ requires webshot and phantomjs to be installed (required for exporting some plots), since the analyze test is actually doing something useful now

@cjyetman cjyetman requested a review from jacobvjk as a code owner December 11, 2024 16:54
Copy link

github-actions bot commented Dec 11, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-12 08:28 UTC

@cjyetman cjyetman marked this pull request as draft December 11, 2024 17:00
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (fd375e1) to head (5008980).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #339       +/-   ##
===========================================
+ Coverage   51.57%   81.02%   +29.45%     
===========================================
  Files          29       29               
  Lines        3205     3205               
===========================================
+ Hits         1653     2597      +944     
+ Misses       1552      608      -944     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjyetman cjyetman marked this pull request as ready for review December 11, 2024 17:45
@cjyetman cjyetman requested a review from jdhoffa December 11, 2024 17:45
@cjyetman cjyetman merged commit ed3e148 into main Dec 12, 2024
11 checks passed
@cjyetman cjyetman deleted the use-valid-scenario-and-source-in-tests branch December 12, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants