Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate matching timestamps #337

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Validate matching timestamps #337

merged 4 commits into from
Dec 12, 2024

Conversation

jacobvjk
Copy link
Member

@jacobvjk jacobvjk commented Dec 11, 2024

closes #327

  • gains validation that entire period between parameters start_year and start_year + time_frame is available in abcd and, where necessary in AI advanced company indicators
  • gains validation that parameter start_year lines up with the initial years of the tms and sda scenario inputs

Copy link

github-actions bot commented Dec 11, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-12 09:49 UTC

@jacobvjk jacobvjk marked this pull request as ready for review December 12, 2024 09:03
@jacobvjk jacobvjk requested a review from cjyetman December 12, 2024 09:03
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (ed3e148) to head (7eae7f9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/prepare_sector_split.R 0.00% 13 Missing ⚠️
R/run_aggregate_alignment_metric.R 36.84% 12 Missing ⚠️
R/run_pacta.R 36.84% 12 Missing ⚠️
R/remove_inactive_companies.R 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   81.02%   80.05%   -0.98%     
==========================================
  Files          29       29              
  Lines        3205     3269      +64     
==========================================
+ Hits         2597     2617      +20     
- Misses        608      652      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cjyetman cjyetman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 looks great!

@jacobvjk jacobvjk merged commit 30445e7 into main Dec 12, 2024
11 checks passed
@jacobvjk jacobvjk deleted the validate-matching-timestamps branch December 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate that timestamps match across inputs
2 participants