Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert all stop() and rlang::abort() commands to cli::cli_abort() #232

Merged
merged 8 commits into from
Nov 13, 2024
Merged

convert all stop() and rlang::abort() commands to cli::cli_abort() #232

merged 8 commits into from
Nov 13, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman requested a review from jacobvjk as a code owner November 12, 2024 20:42
@cjyetman cjyetman requested a review from jdhoffa November 12, 2024 20:47
jacobvjk
jacobvjk requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny correction and a few questions on assert_ naming

R/aggregate_alignment_loanbook_exposure.R Outdated Show resolved Hide resolved
R/plot_scatter.R Outdated Show resolved Hide resolved
R/prep_sankey.R Outdated Show resolved Hide resolved
R/prep_scatter.R Outdated Show resolved Hide resolved
@cjyetman cjyetman linked an issue Nov 13, 2024 that may be closed by this pull request
align utility function prefixes #132
Closed
@cjyetman cjyetman requested a review from jacobvjk November 13, 2024 09:42
@cjyetman cjyetman merged commit 99d120b into main Nov 13, 2024
9 checks passed
@cjyetman cjyetman deleted the rlang-to-cli-abort branch November 13, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobvjk jacobvjk jacobvjk approved these changes

@jdhoffa jdhoffa Awaiting requested review from jdhoffa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

harmonize abort commmands to use cli::cli_abort() align utility function prefixes
2 participants
@cjyetman @jacobvjk