Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the r2dii packages menu #225

Merged
merged 7 commits into from
Nov 13, 2024
Merged

add the r2dii packages menu #225

merged 7 commits into from
Nov 13, 2024

Conversation

@cjyetman cjyetman marked this pull request as ready for review November 13, 2024 09:26
@cjyetman cjyetman requested a review from jacobvjk as a code owner November 13, 2024 09:26
@cjyetman cjyetman requested a review from jdhoffa November 13, 2024 09:26
@jacobvjk
Copy link
Member

there was a comment in the linked issue to wait with this until the package is accepted on CRAN. Have we changed our mind on this?

@cjyetman
Copy link
Member Author

there was a comment in the linked issue to wait with this until the package is accepted on CRAN. Have we changed our mind on this?

I assumed that meant in the reverse case, e.g. adding pacta.multi.loanbook to the menu of the r2dii pkgs' menus. This just adds the r2dii pkgs to pacta.multi.loanbook's menu, which I think is (already) relevant.

Happy to pause on this if you or @jdhoffa prefers though.

@jdhoffa
Copy link
Member

jdhoffa commented Nov 13, 2024

there was a comment in the linked issue to wait with this until the package is accepted on CRAN. Have we changed our mind on this?

I assumed that meant in the reverse case, e.g. adding pacta.multi.loanbook to the menu of the r2dii pkgs' menus. This just adds the r2dii pkgs to pacta.multi.loanbook's menu, which I think is (already) relevant.

Happy to pause on this if you or @jdhoffa prefers though.

Yes exactly this!
Having a dev package on a CRAN website might be confusing.
Having CRAN packages on a dev website is fine

@cjyetman cjyetman merged commit 03d3c10 into main Nov 13, 2024
9 checks passed
@cjyetman cjyetman deleted the add-r2dii-pkgs-menu branch November 13, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider including pacta.multi.loanbook in the "Packages" menu of the r2dii suite
3 participants