Skip to content

Commit

Permalink
Merge various RMI container registries
Browse files Browse the repository at this point in the history
A simple cost saving measure, since each of our (currently) four RMI registries costs like $1/day. I noticed it when checking our Azure credit burn rate.
  • Loading branch information
bcspragu committed Nov 7, 2023
1 parent 5cbf241 commit c7eb3b7
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
allow-no-subscriptions: false

- name: Login to ACR via OIDC
run: az acr login --name rmipacta
run: az acr login --name rmisa

- uses: actions/setup-node@v3
with:
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
containerAppName: pactasrv-dev
containerAppEnvironment: pacta-dev
resourceGroup: rmi-pacta-dev
imageToDeploy: rmipacta.azurecr.io/pacta:dev
imageToDeploy: rmisa.azurecr.io/pacta:dev
location: centralus

- name: Deploy frontend
Expand Down
2 changes: 1 addition & 1 deletion cmd/runner/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ oci_push(
name = "push_image",
image = ":image",
remote_tags = ["latest"],
repository = "rmipacta.azurecr.io/runner",
repository = "rmisa.azurecr.io/runner",
)

# Note: This tarball is provided for local testing of the Docker image, see the README.md for details on usage.
Expand Down
2 changes: 1 addition & 1 deletion cmd/server/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ oci_push(
name = "push_image",
image = ":image",
remote_tags = ["latest"],
repository = "rmipacta.azurecr.io/pacta",
repository = "rmisa.azurecr.io/pacta",
)

# Note: This tarball is provided for local testing of the Docker image, see the README.md for details on usage.
Expand Down
2 changes: 1 addition & 1 deletion cmd/server/configs/local.conf
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ secret_runner_config_identity_subscription_id 69b6db12-37e3-4e1f-b48c-aa41dba612
secret_runner_config_identity_resource_group rmi-pacta-local
secret_runner_config_identity_client_id c02b7346-6ba6-438a-8136-1ccb608e5449
secret_runner_config_identity_managed_environment pacta-local
secret_runner_config_image_registry rmipacta.azurecr.io
secret_runner_config_image_registry rmisa.azurecr.io
secret_runner_config_image_name runner
2 changes: 1 addition & 1 deletion cmd/server/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func run(args []string) error {
runnerConfigIdentityClientID = fs.String("secret_runner_config_identity_client_id", "", "Client ID of the identity to run runner jobs with")
runnerConfigIdentityManagedEnvironment = fs.String("secret_runner_config_identity_managed_environment", "", "Name of the Container Apps Environment where runner jobs should run")

runnerConfigImageRegistry = fs.String("secret_runner_config_image_registry", "", "Registry where PACTA runner images live, like 'rmipacta.azurecr.io'")
runnerConfigImageRegistry = fs.String("secret_runner_config_image_registry", "", "Registry where PACTA runner images live, like 'rmisa.azurecr.io'")
runnerConfigImageName = fs.String("secret_runner_config_image_name", "", "Name of the Docker image of the PACTA runner, like 'runner'")
)
// Allows for passing in configuration via a -config path/to/env-file.conf
Expand Down
2 changes: 1 addition & 1 deletion task/task.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type EnvVar struct {
}

type BaseImage struct {
// Like 'rmipacta.azurecr.io'
// Like 'rmisa.azurecr.io'
Registry string
// Like 'runner'
Name string
Expand Down

0 comments on commit c7eb3b7

Please sign in to comment.