From 3d6a0a4109d8a3a96142be99c0eaafdeae31faf4 Mon Sep 17 00:00:00 2001
From: Grady Ward <grady.b.ward@gmail.com>
Date: Sat, 20 Jan 2024 19:46:29 -0700
Subject: [PATCH] Holdings Date Fixes

---
 cmd/server/pactasrv/portfolio.go                          | 7 +++++++
 frontend/components/form/FieldHeader.vue                  | 2 +-
 .../inputs/{HoldingDate.vue => HoldingsDate.vue}          | 0
 frontend/components/portfolio/Editor.vue                  | 8 ++++++++
 frontend/lang/en.json                                     | 4 +++-
 frontend/pages/upload.vue                                 | 2 +-
 6 files changed, 20 insertions(+), 3 deletions(-)
 rename frontend/components/inputs/{HoldingDate.vue => HoldingsDate.vue} (100%)

diff --git a/cmd/server/pactasrv/portfolio.go b/cmd/server/pactasrv/portfolio.go
index b93f5a2..41adde6 100644
--- a/cmd/server/pactasrv/portfolio.go
+++ b/cmd/server/pactasrv/portfolio.go
@@ -90,6 +90,13 @@ func (s *Server) UpdatePortfolio(ctx context.Context, request api.UpdatePortfoli
 	if request.Body.Description != nil {
 		mutations = append(mutations, db.SetPortfolioDescription(*request.Body.Description))
 	}
+	if request.Body.PropertyHoldingsDate != nil {
+		hd, err := conv.HoldingsDateFromOAPI(request.Body.PropertyHoldingsDate)
+		if err != nil {
+			return nil, err
+		}
+		mutations = append(mutations, db.SetPortfolioPropertyHoldingsDate(hd))
+	}
 	if request.Body.PropertyESG != nil {
 		mutations = append(mutations, db.SetPortfolioPropertyESG(conv.OptionalBoolFromOAPI(*request.Body.PropertyESG)))
 	}
diff --git a/frontend/components/form/FieldHeader.vue b/frontend/components/form/FieldHeader.vue
index d7a2d18..5289171 100644
--- a/frontend/components/form/FieldHeader.vue
+++ b/frontend/components/form/FieldHeader.vue
@@ -66,7 +66,7 @@ const helpTextTextClass = computed(() => helpTextExpanded.value ? 'mb-2' : 'h-0'
     <div
       v-if="helpTextExists"
       :class="helpTextTextClass"
-      class="overflow-hidden ml-1 text-sm help-text-animate"
+      class="overflow-hidden text-sm help-text-animate"
     >
       <slot name="help-text" />
       {{ props.helpText }}
diff --git a/frontend/components/inputs/HoldingDate.vue b/frontend/components/inputs/HoldingsDate.vue
similarity index 100%
rename from frontend/components/inputs/HoldingDate.vue
rename to frontend/components/inputs/HoldingsDate.vue
diff --git a/frontend/components/portfolio/Editor.vue b/frontend/components/portfolio/Editor.vue
index 05bb713..db5b55e 100644
--- a/frontend/components/portfolio/Editor.vue
+++ b/frontend/components/portfolio/Editor.vue
@@ -40,6 +40,14 @@ const evs = computed({
         auto-resize
       />
     </FormEditorField>
+    <FormEditorField
+      :editor-field="efs.propertyHoldingsDate"
+      :editor-value="evs.propertyHoldingsDate"
+    >
+      <InputsHoldingsDate
+        v-model:value="evs.propertyHoldingsDate.currentValue"
+      />
+    </FormEditorField>
     <FormEditorField
       :editor-field="efs.propertyESG"
       :editor-value="evs.propertyESG"
diff --git a/frontend/lang/en.json b/frontend/lang/en.json
index 9feec45..53ae04a 100644
--- a/frontend/lang/en.json
+++ b/frontend/lang/en.json
@@ -314,7 +314,9 @@
     "External": "External",
     "ExternalHelpText": "If enabled, this portfolio represents external data. If disabled, this portfolio represents internal data.",
     "Engagement Strategy": "Engagement Strategy",
-    "EngagementStrategyHelpText": "If enabled, this portfolio represents engagement strategy data. If disabled, this portfolio represents non-engagement strategy data."
+    "EngagementStrategyHelpText": "If enabled, this portfolio represents engagement strategy data. If disabled, this portfolio represents non-engagement strategy data.",
+    "Holdings Date": "Holdings Date",
+    "HoldingsDateHelpText": "The date that the holdings in this portfolio are being evaluated at."
   },
   "lib/editor/portfolio_group": {
     "Created At": "Created At",
diff --git a/frontend/pages/upload.vue b/frontend/pages/upload.vue
index dd87348..07b3d49 100644
--- a/frontend/pages/upload.vue
+++ b/frontend/pages/upload.vue
@@ -374,7 +374,7 @@ const cleanUpIncompleteUploads = async () => {
             label="Holdings Date"
             help-text="The holdings date for the portfolio"
           >
-            <InputsHoldingDate
+            <InputsHoldingsDate
               v-model:value="holdingsDate"
               :disabled="isProcessing"
             />