Additional small changes

[Clare2D]

A few additional changes that I thought of yesterday to improve a few things.

• changing the parameter file name (dropping the _GENERAL) this is important so we don't end up changing the "ProjectParameters_GENERAL" that will be used online.
• changed the other_sector_list parameter to refer to the name it has in the parameter file already

[maurolepore]

@Clare2D, I removed all that deals with style and paste0() to make this PR easier to understand and review. I'll submit those changes in a follow up PR.

@cjyetman can you please see if this PR raises any concern?

[maurolepore]

This reverts what we did in #398

Is there a reason to prefer the more fragile pattern = "_Input.csv" over the more robust pattern = "_Input[.]csv$"?

[cjyetman]

I believe almost everything here is related only to the "offline" version of running PACTA, and does not affect the web tool scripts, so it seems pretty safe from that perspective. I don't know or understand the reason or context for most of these changes, so I can't really judge that much.

The one thing that does concern me a bit it is the change to 0_portfolio_input_check_functions.R on L421 that changes other_sector_list to pacta_sectors_not_analysed... primarily because that could be something that affects the web tool scripts via get_and_clean_fin_data(), and I don't know anything about the purpose of that change, or if or where those objects do or do not exist.