Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Clean web tool script 3 #350

Merged
merged 25 commits into from
Nov 26, 2020
Merged

Clean web tool script 3 #350

merged 25 commits into from
Nov 26, 2020

Conversation

Clare2D
Copy link
Contributor

@Clare2D Clare2D commented Nov 25, 2020

This is a significant PR with a few different functions. @jacobvjk this will allow us to have stress test functions across the scripts.

Aims:

Needs to be run in conjunction with updates to pacta-data that will be turned into a PR soon.
https://github.com/2DegreesInvesting/pacta-data/pull/19
https://github.com/2DegreesInvesting/create_interactive_report/pull/276
https://github.com/2DegreesInvesting/StressTestingModelDev/pull/121

@Clare2D Clare2D requested a review from cjyetman November 25, 2020 07:51
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy to see this. lgtm, but I won't approve, as I think CJ has a better understanding of the project parameters.

@Clare2D Clare2D marked this pull request as ready for review November 25, 2020 13:38
@Clare2D
Copy link
Contributor Author

Clare2D commented Nov 25, 2020

This also merges the AnalysisParameters file into the new Projectparameters_xxxx fil This was discussed with @cjyetman and will hopefully remove confusion. For each PACTA run what needs to be defined:

  • Project Parameters (apply for all participants)
  • Portfolio Parameters (unique to a single participants - defines only which project they are participating in)

@cjyetman
Copy link
Member

this works for me locally with everything as is

  1. didn't we discuss removing completely AnalysisParameters.yml from the root level?

  2. when I change the project code in working_dir/10_Parameter_File/TestPortfolio_Input_PortfolioParameters.yml to "PA2020FL", everything seems to work as expected except that the Executive Summary is still triggered, for which there is currently no template for in create_interactive_report, and thus triggers an error... is that expected, or do we need to prevent that from happening (i.e. will there eventually be a template for that in create_interactive_report)?

@Clare2D
Copy link
Contributor Author

Clare2D commented Nov 26, 2020

Thanks CJ. I've now removed those remaining AnalysisParameter files and added in some initial exec summary files for Liechtenstein. Otherwise the error is to be expected.

@cjyetman
Copy link
Member

cool... then I'm gonna approve these PRs... up to you to merge...
/pull/350
2DegreesInvesting/pacta-data/pull/19
2DegreesInvesting/create_interactive_report/pull/276
2DegreesInvesting/StressTestingModelDev/pull/121

@Clare2D
Copy link
Contributor Author

Clare2D commented Nov 26, 2020

Woohoo! Thanks.

@Clare2D Clare2D merged commit cde1e2e into master Nov 26, 2020
@Clare2D Clare2D deleted the clean-web_tool_script_3 branch November 26, 2020 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants