This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
new function for calculating SDA #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
significant work is still required to implement the "market adjustment" part of the calculation |
cjyetman
requested review from
FrederickFa,
jdhoffa,
georgeharris2deg and
AlexAxthelm
|
relevant info about the "market adjustment" |
|
since this repo is deprecated, and this issue is tracked here https://github.com/RMI-PACTA/pacta.data.preparation/issues/127 and here https://github.com/RMI-PACTA/pacta.portfolio.analysis/issues/81, I agree |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #433
This PR implements a new SDA calculating function. It has substantially different api and behaviour, and it is intended to completely replace the old, problematic
sda_portfolio_target().This is a draft. It includes an example usage script which should not be included if/when this is merged.