Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Check company classifications #380

Open
Clare2D opened this issue Jan 14, 2021 · 3 comments
Open

Check company classifications #380

Clare2D opened this issue Jan 14, 2021 · 3 comments
Assignees
Labels
bug Something isn't working high-priority

Comments

@Clare2D
Copy link
Contributor

Clare2D commented Jan 14, 2021

I noticed in the interactive report that Siemens is classified as a Power company and they are not. This should be included in the overrides functionality. I will check why they are not classified as Other

@Clare2D Clare2D added the bug Something isn't working label Jan 14, 2021
@Clare2D Clare2D self-assigned this Jan 14, 2021
@cjyetman
Copy link
Member

cjyetman commented Dec 4, 2021

will discuss this with AR in the next meeting and go from there

@cjyetman
Copy link
Member

cjyetman commented Dec 4, 2021

maybe this happens because of the mix up about where sectors are merged/defined and possible sets of overrides that are not in sync?
see...
#343
2DegreesInvesting/data_preparation/issues/14

@cjyetman
Copy link
Member

cjyetman commented Dec 8, 2021

It's clear that line 191 in this file probably played a role in this: data/fin_sector_overrides.csv

company_name corporate_bond_ticker bloomberg_id fin_sector_override
SIEMENS AG   115746 Power

however, it's not clear to me if this data/fin_sector_overrides.csv or this one 2DegreesInvesting/data_preparation/data-raw/fin_sector_overrides.csv is currently relevant (the latter does not include "SIEMENS AG' or any reasonable variation)

There have been discussions in #343 and 2DegreesInvesting/data_preparation/issues/14 about the confusion between having and maintaining multiple copies of this file (there's also one in stress testing here: r2dii.stress.test.data/data-raw/fin_sector_overrides.csv).

I think maybe this will get addressed when 2DegreesInvesting/data_preparation/issues/14 is addressed, just leaving lots of links pointing to all relevant stuff for the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working high-priority
Projects
None yet
Development

No branches or pull requests

2 participants