Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

Change the mapped sector of the company fin data #343

Open
Clare2D opened this issue Nov 24, 2020 · 2 comments
Open

Change the mapped sector of the company fin data #343

Clare2D opened this issue Nov 24, 2020 · 2 comments
Assignees
Labels
bug Something isn't working high-priority

Comments

@Clare2D
Copy link
Contributor

Clare2D commented Nov 24, 2020

As @2diiKlaus flagged, the fin sector overrides of the mapped sector in the comp_fin_data is not occurring. This should be part of the work that @cjyetman is doing to refactor this code.

Specifically this means:

  • merging in the fin sector overrides as is done for the security level financial data.
@2diiKlaus
Copy link

2diiKlaus commented Nov 24, 2020

Not even sure if it is done for securities well enough - could check listed equity instruments for :
ThyssenKrupp, Siemens, 3m co, ... basically ICB = "Diversified Industrials" as these are classified as Power which is wrong in almost all cases

@cjyetman
Copy link
Member

this will probably be dealt with here 2DegreesInvesting/data_preparation/issues/14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working high-priority
Projects
None yet
Development

No branches or pull requests

3 participants