Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues with Dark Mode #157

Open
jackrua opened this issue Feb 18, 2024 · 3 comments
Open

Some issues with Dark Mode #157

jackrua opened this issue Feb 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request frontend This is frontend related

Comments

@jackrua
Copy link
Contributor

jackrua commented Feb 18, 2024

If you set Dark Mode, the colors in the line chart do not change.
This point is already addressed in the code:

LineChartWidget(
line1Data: currentMonthList,
colorLine1Data: const Color(0xff00152D),
line2Data: lastMonthList,
colorLine2Data: const Color(0xffB9BABC), //da modificare in darkMode
colorBackground: Theme.of(context).colorScheme.tertiary,
),

We could use something like blue6 (0xFF7DA1C4) to get a nice contrast:

p3

Moreover all the account and category icons should be switched to Dark Mode in different pages (only in the settings page they are updated while, for example, in the home page they are not).

Finally in the transactions page, if you switch to Dark Mode the month selector creates so much contrast that is almost unreadable:

p4

@theperu
Copy link
Collaborator

theperu commented Feb 18, 2024

Hi! There is an open PR which addressed a few issues that were already found about the dark mode, if you want you could pick it up so that we can solve all the problems that we currently have for the theme

@theperu theperu added enhancement New feature or request frontend This is frontend related labels Feb 18, 2024
@diegodiome
Copy link

Can I work on this? There are still some issues, such as the transaction selector and line graph tooltip.

@theperu
Copy link
Collaborator

theperu commented Apr 11, 2024

Yes @diegodiome, if you want you can also take a look at the open PR for the dark theme #124 which fixed some things but not all 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend This is frontend related
Projects
None yet
Development

No branches or pull requests

3 participants