Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFAssignR: separate signal-to-noise input into ratio and noise in IsoFiltR #588

Closed
KristinaGomoryova opened this issue Oct 16, 2024 · 1 comment · Fixed by #594
Closed

MFAssignR: separate signal-to-noise input into ratio and noise in IsoFiltR #588

KristinaGomoryova opened this issue Oct 16, 2024 · 1 comment · Fixed by #594

Comments

@KristinaGomoryova
Copy link
Collaborator

In the IsoFiltR function, separate the signal-to-noise input into ratio and estimated_noise from the KMDnoise function (similarly as it's done in other functions).
@KristinaGomoryova KristinaGomoryova mentioned this issue Oct 16, 2024
Merged
@hechth
Copy link
Member

hechth commented Oct 21, 2024

This should also be done in the SNplot function where the cut is passed as a single parameter, just to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

signal-to-noise separated into ratio and noise in IsoFiltR KristinaGomoryova/galaxytools
2 participants
@hechth @KristinaGomoryova