Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled key conversion in matchms tools #484

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

zargham-ahmad
Copy link
Collaborator

@zargham-ahmad zargham-ahmad commented Jan 29, 2024

This PR include the following:

closes #480

Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adress the single comment, otherwise looks good - maybe lets include the string sanitizing issue also in this PR as it is related to matchms add key?

tools/matchms/matchms_subsetting.xml Show resolved Hide resolved
@zargham-ahmad
Copy link
Collaborator Author

Please adress the single comment, otherwise looks good - maybe lets include the string sanitizing issue also in this PR as it is related to matchms add key?

done in 72512a3

@hechth hechth merged commit da19386 into RECETOX:master Feb 5, 2024
13 checks passed
@hechth hechth linked an issue Feb 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle string sanitzing in matchms add key tool Disable key conversion in data handling matchms tools
2 participants