Matchms networking: error message #443
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not necessary. also all quotes. and remove linebreaks
this currently only gives a python Traceback that is hard to read by the user. Can this be improved in the wrapper / matchms?
bgruening
approved these changes
Nov 23, 2023
|
Please don't merge yet. Would like to see first if we can get a better error message in stderr? Ping @hechth |
|
@bernt-matthias soo whats up with this here? Anything I can do? |
|
Question is if there should/can be a proper error message instead of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test currently gives a python Traceback that is hard to read by users. Can this be improved in the wrapper / matchms?