Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the graph editor in the story pages #98

Open
4 tasks
Maartenvm opened this issue Aug 16, 2021 · 1 comment
Open
4 tasks

Add the graph editor in the story pages #98

Maartenvm opened this issue Aug 16, 2021 · 1 comment

Comments

@Maartenvm
Copy link

Maartenvm commented Aug 16, 2021

image

Image says all...

  • Add button to open dialog
  • Dialog to edit graph from the page editor.
  • Add the Vega Lite editor to an iframe
  • Make a short 'tutorial' on the page itself to guide the user to copy URLs and text to the right boxes.
@kretep
Copy link
Member

kretep commented Aug 16, 2021

Maybe for later, but to make sure we don't forget: instead of using an iframe, we could use the Monaco editor for editing the vega json. This editor is used in the vega editor (and also in VSCode btw) to edit the json and supports autocompletion out of the box because there is a schema available. The generated chart could easily be updated using the embed function.

@Maartenvm Maartenvm added this to the Pre-release of the Builder milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants